netdev - RE: [Intel-wired-lan] [PATCH intel-net 1/2] ice: check (DD | EOF) bits on Rx descriptor rather than (EOP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH0PR11MB51443780ED94392E02191A38E2949@PH0PR11MB5144.namprd11.prod.outlook.com>
Date:   Tue, 26 Jul 2022 18:14:33 +0000
From:   "Kuruvinakunnel, George" <george.kuruvinakunnel@...el.com>
To:     "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "john.fastabend@...il.com" <john.fastabend@...il.com>,
        "Gerasymenko, Anatolii" <anatolii.gerasymenko@...el.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "Karlsson, Magnus" <magnus.karlsson@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH intel-net 1/2] ice: check (DD | EOF)
 bits on Rx descriptor rather than (EOP | RS)

> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Maciej
> Fijalkowski
> Sent: Thursday, July 7, 2022 3:51 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; john.fastabend@...il.com; Gerasymenko, Anatolii
> <anatolii.gerasymenko@...el.com>; kuba@...nel.org; davem@...emloft.net;
> Karlsson, Magnus <magnus.karlsson@...el.com>
> Subject: [Intel-wired-lan] [PATCH intel-net 1/2] ice: check (DD | EOF) bits on Rx
> descriptor rather than (EOP | RS)
> 
> Tx side sets EOP and RS bits on descriptors to indicate that a particular descriptor is
> the last one and needs to generate an irq when it was sent. These bits should not be
> checked on completion path regardless whether it's the Tx or the Rx. DD bit serves
> this purpose and it indicates that a particular descriptor is either for Rx or was
> successfully Txed. EOF is also set as loopback test does not xmit fragmented
> frames.
> 
> Look at (DD | EOF) bits setting in ice_lbtest_receive_frames() instead of EOP and RS
> pair.
> 
> Fixes: 0e674aeb0b77 ("ice: Add handler for ethtool selftest")
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_ethtool.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 

Tested-by: George Kuruvinakunnel <george.kuruvinakunnel@...el.com>