netdev - [PATCH net-next 1/1] tcp: Remove useless acceptable check because the return vlaue always is 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <OSZP286MB1404946FF81173281D3BF67695949@OSZP286MB1404.JPNP286.PROD.OUTLOOK.COM>
Date:   Wed, 27 Jul 2022 06:58:03 +0800
From:   gfree.wind@...look.com
To:     edumazet@...gle.com, davem@...emloft.net, yoshfuji@...ux-ipv6.org,
        dsahern@...nel.org, kuba@...nel.org, pabeni@...hat.com,
        netdev@...r.kernel.org
Cc:     gfree.wind@...look.com, Gao Feng <gfree.wind@...il.com>
Subject: [PATCH net-next 1/1] tcp: Remove useless acceptable check because the return vlaue always is 0

From: Gao Feng <gfree.wind@...il.com>

The conn_request function of IPv4 and IPv6 always returns 0, so it's
useless to check for acceptable.

Signed-off-by: Gao Feng <gfree.wind@...il.com>
---
 net/ipv4/tcp_input.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index 3ec4edc37313..82a875efd1e8 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -6453,12 +6453,11 @@ int tcp_rcv_state_process(struct sock *sk, struct sk_buff *skb)
 			 */
 			rcu_read_lock();
 			local_bh_disable();
-			acceptable = icsk->icsk_af_ops->conn_request(sk, skb) >= 0;
+			/* TCP's conn_request always returns 0. */
+			icsk->icsk_af_ops->conn_request(sk, skb);
 			local_bh_enable();
 			rcu_read_unlock();
 
-			if (!acceptable)
-				return 1;
 			consume_skb(skb);
 			return 0;
 		}
-- 
2.25.1