netdev - Re: [PATCH net-next v5 27/27] selftests/io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e4f4c89c-cdc5-2a37-c087-1c356a2a425a@gmail.com>
Date:   Wed, 27 Jul 2022 10:18:56 +0100
From:   Pavel Begunkov <asml.silence@...il.com>
To:     dust.li@...ux.alibaba.com, io-uring@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Jonathan Lemon <jonathan.lemon@...il.com>,
        Willem de Bruijn <willemb@...gle.com>,
        Jens Axboe <axboe@...nel.dk>, David Ahern <dsahern@...nel.org>,
        kernel-team@...com
Subject: Re: [PATCH net-next v5 27/27] selftests/io_uring: test zerocopy send

On 7/27/22 09:01, dust.li wrote:

>> +static void do_test(int domain, int type, int protocol)
>> +{
>> +	int i;
>> +
>> +	for (i = 0; i < IP_MAXPACKET; i++)
>> +		payload[i] = 'a' + (i % 26);
>> +	do_tx(domain, type, protocol);
>> +}
>> +
>> +static void usage(const char *filepath)
>> +{
>> +	error(1, 0, "Usage: %s [-f] [-n<N>] [-z0] [-s<payload size>] "
>> +		    "(-4|-6) [-t<time s>] -D<dst_ip> udp", filepath);
> 
> A small flaw, the usage here doesn't match the real options in parse_opts().

Indeed. I'll adjust it, thanks!

-- 
Pavel Begunkov