[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20220727094146.5990-1-zeming@nfschina.com>
Date: Wed, 27 Jul 2022 17:41:46 +0800
From: Li zeming <zeming@...china.com>
To: jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
Li zeming <zeming@...china.com>
Subject: [PATCH] sched/net/act: Remove temporary state variables
The temporary variable ret could be removed and the corresponding state
can be directly returned.
Signed-off-by: Li zeming <zeming@...china.com>
---
net/sched/act_api.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/net/sched/act_api.c b/net/sched/act_api.c
index 817065aa2833..34b5eb52e68b 100644
--- a/net/sched/act_api.c
+++ b/net/sched/act_api.c
@@ -398,8 +398,6 @@ static int __tcf_action_put(struct tc_action *p, bool bind)
static int __tcf_idr_release(struct tc_action *p, bool bind, bool strict)
{
- int ret = 0;
-
/* Release with strict==1 and bind==0 is only called through act API
* interface (classifiers always bind). Only case when action with
* positive reference count and zero bind count can exist is when it was
@@ -417,10 +415,10 @@ static int __tcf_idr_release(struct tc_action *p, bool bind, bool strict)
return -EPERM;
if (__tcf_action_put(p, bind))
- ret = ACT_P_DELETED;
+ return ACT_P_DELETED;
}
- return ret;
+ return 0;
}
int tcf_idr_release(struct tc_action *a, bool bind)
--
2.18.2
Powered by blists - more mailing lists