lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20220727145802.is7teuybcgzwpbvg@skbuf> Date: Wed, 27 Jul 2022 17:58:02 +0300 From: Vladimir Oltean <olteanv@...il.com> To: Marcin Wojtas <mw@...ihalf.com> Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org, andrew@...n.ch, vivien.didelot@...il.com, f.fainelli@...il.com, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, linux@...linux.org.uk, jaz@...ihalf.com, tn@...ihalf.com, upstream@...ihalf.com Subject: Re: [net-next: PATCH v2] net: dsa: mv88e6xxx: fix speed setting for CPU/DSA ports On Wed, Jul 27, 2022 at 01:09:18AM +0200, Marcin Wojtas wrote: > Commit 3c783b83bd0f ("net: dsa: mv88e6xxx: get rid of SPEED_MAX setting") > stopped relying on SPEED_MAX constant and hardcoded speed settings > for the switch ports and rely on phylink configuration. > > It turned out, however, that when the relevant code is called, > the mac_capabilites of CPU/DSA port remain unset. > mv88e6xxx_setup_port() is called via mv88e6xxx_setup() in > dsa_tree_setup_switches(), which precedes setting the caps in > phylink_get_caps down in the chain of dsa_tree_setup_ports(). > > As a result the mac_capabilites are 0 and the default speed for CPU/DSA > port is 10M at the start. To fix that, execute mv88e6xxx_get_caps() > and obtain the capabilities driectly. > > Fixes: 3c783b83bd0f ("net: dsa: mv88e6xxx: get rid of SPEED_MAX setting") > Signed-off-by: Marcin Wojtas <mw@...ihalf.com> > --- Reviewed-by: Vladimir Oltean <olteanv@...il.com>
Powered by blists - more mailing lists