netdev - Re: question on MAC passthrough and multiple devices in r8152

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220727090900.75d2b7b8@kernel.org>
Date:   Wed, 27 Jul 2022 09:09:00 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Oliver Neukum <oneukum@...e.com>
Cc:     Hayes Wang <hayeswang@...ltek.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: question on MAC passthrough and multiple devices in r8152

On Wed, 27 Jul 2022 12:51:44 +0200 Oliver Neukum wrote:
> I am looking at the logic the r8152 driver uses to
> assign a pass through MAC and I do not understand how
> you make sure that it is passed to one device only.
> As far as I can see the MAC comes from an ACPI object,
> hence the driver will happily read it out and assign
> it multiple times. Am I overlooking something?

Just to be sure - have you seen the giant threads on the topic?
IIRC lenovo was sending patches to extend the mechanism, broke
some people's setups and to much teeth grinding we accepted the
somewhat improved patches and moved on. The entire mechanism is
quite poorly designed, we couldn't come up with a better way :(