netdev - RE: handling MAC set by user space in reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6ed729b080c04fc8b93b43b09cf42be0@realtek.com>
Date:   Thu, 28 Jul 2022 09:41:16 +0000
From:   Hayes Wang <hayeswang@...ltek.com>
To:     Oliver Neukum <oneukum@...e.com>
CC:     USB list <linux-usb@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: handling MAC set by user space in reset_resume() of r8152

Oliver Neukum <oneukum@...e.com>
[...]
> OK, thank you. Do you agree that a manually set MAC needs to be kept
> even through a pre/post_reset() and reset_resume(), while a MAC passed
> through needs to be reevaluated at pre/post_reset() but not at
> reset_resume()

Yes. I think a user wishes to keep it.

> > Besides, I don't understand why you set tp->external_mac = false
> > in rtl8152_down().
> 
> Frankly I need to undo the effect of ndo_set_mac_address()
> at some time, but it is unclear to me how to return a network
> interface to its "native" MAC.
> Any ideas?

I am not sure. Is it necessary?
If I change the MAC address, I don't hope it is recovered unexpectedly
unless the system is rebooted or shutdown.

Best Regards,
Hayes