[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <165900225429.25113.8345553765798520539.kvalo@kernel.org>
Date: Thu, 28 Jul 2022 09:57:36 +0000 (UTC)
From: Kalle Valo <kvalo@...nel.org>
To: Paul Cercueil <paul@...pouillou.net>
Cc: Arend van Spriel <aspriel@...il.com>,
Franky Lin <franky.lin@...adcom.com>,
linux-wireless@...r.kernel.org,
brcm80211-dev-list.pdl@...adcom.com,
SHA-cyfmac-dev-list@...ineon.com, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, Paul Cercueil <paul@...pouillou.net>
Subject: Re: [v3] wifi: brcmfmac: Remove #ifdef guards for PM related
functions
Paul Cercueil <paul@...pouillou.net> wrote:
> Use the new DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr() macros to
> handle the .suspend/.resume callbacks.
>
> These macros allow the suspend and resume functions to be automatically
> dropped by the compiler when CONFIG_SUSPEND is disabled, without having
> to use #ifdef guards.
>
> Some other functions not directly called by the .suspend/.resume
> callbacks, but still related to PM were also taken outside #ifdef
> guards.
>
> The advantage is then that these functions are now always compiled
> independently of any Kconfig option, and thanks to that bugs and
> regressions are easier to catch.
>
> Signed-off-by: Paul Cercueil <paul@...pouillou.net>
Patch applied to wireless-next.git, thanks.
02a186f1e96b wifi: brcmfmac: Remove #ifdef guards for PM related functions
--
https://patchwork.kernel.org/project/linux-wireless/patch/20220627193701.31074-1-paul@crapouillou.net/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists