netdev - RE: [PATCH iproute-next v3 3/3] f_flower: Introduce PPPoE support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MW4PR11MB5776C1D8CC2CAF39C05F3928FD969@MW4PR11MB5776.namprd11.prod.outlook.com>
Date:   Thu, 28 Jul 2022 11:21:52 +0000
From:   "Drewek, Wojciech" <wojciech.drewek@...el.com>
To:     Guillaume Nault <gnault@...hat.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "dsahern@...il.com" <dsahern@...il.com>,
        "stephen@...workplumber.org" <stephen@...workplumber.org>
Subject: RE: [PATCH iproute-next v3 3/3] f_flower: Introduce PPPoE support



> -----Original Message-----
> From: Guillaume Nault <gnault@...hat.com>
> Sent: czwartek, 28 lipca 2022 13:18
> To: Drewek, Wojciech <wojciech.drewek@...el.com>
> Cc: netdev@...r.kernel.org; dsahern@...il.com; stephen@...workplumber.org
> Subject: Re: [PATCH iproute-next v3 3/3] f_flower: Introduce PPPoE support
> 
> On Thu, Jul 28, 2022 at 01:01:17PM +0200, Wojciech Drewek wrote:
> > Introduce PPPoE specific fields in tc-flower:
> > - session id (16 bits)
> > - ppp protocol (16 bits)
> > Those fields can be provided only when protocol was set to
> > ETH_P_PPP_SES. ppp_proto works similar to vlan_ethtype, i.e.
> > ppp_proto overwrites eth_type. Thanks to that, fields from
> > encapsulated protocols (such as src_ip) can be specified.
> 
> Acked-by: Guillaume Nault <gnault@...hat.com>
> 
> Thanks for working on PPP/PPPoE!

It's our pleasure. Thanks for your involvement in the review!