netdev - Re: [PATCH net-next v2 12/14] sfc: set EF100 VF MAC address through representor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67138e0a-9b89-c99a-6eb1-b5bdd316196f@gmail.com>
Date:   Thu, 28 Jul 2022 16:47:36 +0100
From:   Edward Cree <ecree.xilinx@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>, ecree@...inx.com
Cc:     davem@...emloft.net, pabeni@...hat.com, linux-net-drivers@....com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 12/14] sfc: set EF100 VF MAC address through
 representor

On 28/07/2022 04:10, Jakub Kicinski wrote:
> On Wed, 27 Jul 2022 18:46:02 +0100 ecree@...inx.com wrote:
>> From: Edward Cree <ecree.xilinx@...il.com>
>>
>> When setting the VF rep's MAC address, set the provisioned MAC address
>>  for the VF through MC_CMD_SET_CLIENT_MAC_ADDRESSES.
> 
> Wait.. hm? The VF rep is not the VF. It's the other side of the wire.
> Are you passing the VF rep's MAC on the VF? Ethernet packets between
> the hypervisor and the VF would have the same SA and DA.
> 

Yes (but only if there's an IP stack on the repr; I think it's fine if
 the repr is plugged straight into a bridge so any ARP picks up a
 different DA?).
I thought that was weird but I also thought that was 'how it's done'
 with reps — properties of the VF are set by applying them to the rep.
Is there some other way to configure VF MAC?  (Are we supposed to still
 be using the legacy SR-IOV interface, .ndo_set_vf_mac()?  I thought
 that was deprecated in favour of more switchdev-flavoured stuff…)

-ed