netdev - Re: [PATCH] net: gro: skb_gro_header_try

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ceaf6af0-de27-01b7-c84c-5699ae2a0b8d@kernel.org>
Date:   Thu, 28 Jul 2022 10:06:57 -0600
From:   David Ahern <dsahern@...nel.org>
To:     Richard Gobert <richardbgobert@...il.com>, davem@...emloft.net,
        kuba@...nel.org, pabeni@...hat.com, yoshfuji@...ux-ipv6.org,
        xeb@...l.ru, edumazet@...gle.com, iwienand@...hat.com,
        arnd@...db.de, netdev@...r.kernel.org
Subject: Re: [PATCH] net: gro: skb_gro_header_try_fast helper function

On 7/28/22 5:39 AM, Richard Gobert wrote:
> @@ -160,6 +160,17 @@ static inline void *skb_gro_header_slow(struct sk_buff *skb, unsigned int hlen,
>  	return skb->data + offset;
>  }
>  
> +static inline void *skb_gro_header_try_fast(struct sk_buff *skb,
> +					unsigned int hlen, unsigned int offset)
> +{
> +	void *ptr;
> +
> +	ptr = skb_gro_header_fast(skb, offset);
> +	if (skb_gro_header_hard(skb, hlen))
> +		ptr = skb_gro_header_slow(skb, hlen, offset);
> +	return ptr;
> +}
> +


skb_get_gro_header() or just skb_gro_header() since it does fast then
slow variants?