netdev - Re: [PATCH v2 net] net: ping6: Fix memleak in ipv6_renew

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 Jul 2022 18:50:01 +0200
From:   Eric Dumazet <edumazet@...gle.com>
To:     Kuniyuki Iwashima <kuniyu@...zon.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        David Ahern <dsahern@...nel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Lorenzo Colitti <lorenzo@...gle.com>,
        Benjamin Herrenschmidt <benh@...zon.com>,
        Ayushman Dutta <ayudutta@...zon.com>,
        netdev <netdev@...r.kernel.org>,
        syzbot+a8430774139ec3ab7176@...kaller.appspotmail.com
Subject: Re: [PATCH v2 net] net: ping6: Fix memleak in ipv6_renew_options().

On Thu, Jul 28, 2022 at 3:22 AM Kuniyuki Iwashima <kuniyu@...zon.com> wrote:
>
> When we close ping6 sockets, some resources are left unfreed because
> pingv6_prot is missing sk->sk_prot->destroy().  As reported by
> syzbot [0], just three syscalls leak 96 bytes and easily cause OOM.
>

>
> Fixes: 6d0bfe226116 ("net: ipv6: Add IPv6 support to the ping socket.")
> Reported-by: syzbot+a8430774139ec3ab7176@...kaller.appspotmail.com
> Reported-by: Ayushman Dutta <ayudutta@...zon.com>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>
> ---
> v2:
>   - Remove ip6_flush_pending_frames() (Jakub Kicinski)

Nice catch, thanks.

Reviewed-by: Eric Dumazet <edumazet@...gle.com>