netdev - Re: [PATCH net v2] netrom: fix sleep in atomic context bugs in timer handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7ee70f8a.625d3.182428f792f.Coremail.duoming@zju.edu.cn>
Date:   Thu, 28 Jul 2022 10:07:55 +0800 (GMT+08:00)
From:   duoming@....edu.cn
To:     "Jakub Kicinski" <kuba@...nel.org>
Cc:     linux-hams@...r.kernel.org, ralf@...ux-mips.org,
        davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v2] netrom: fix sleep in atomic context bugs in
 timer handlers

Hello,

On Wed, 27 Jul 2022 18:36:47 -0700 Jakub Kicinski wrote:

> On Tue, 26 Jul 2022 11:24:20 +0800 Duoming Zhou wrote:
> > nr_heartbeat_expiry
> >   nr_write_internal
> >     nr_transmit_buffer
> 
> void nr_transmit_buffer(struct sock *sk, struct sk_buff *skb)
> {
> [...]
> 	if (!nr_route_frame(skb, NULL)) {
> 
> >       nr_route_frame
> 
> int nr_route_frame(struct sk_buff *skb, ax25_cb *ax25)
> {
> [...]
> 	if (ax25 != NULL) {
> 		ret = nr_add_node(nr_src, "", &ax25->dest_addr, ax25->digipeat,
> 
> ax25 must be NULL on this path AFAICT.
> 
> >         nr_add_node
> >           kmemdup(..,GFP_KERNEL) //may sleep

Thank you for your time and suggestions, I understand.

Best regards,
Duoming Zhou