netdev - Re: [RFC] r8152: pass through needs to be singular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YuMJhAuZVVZtl9VZ@lunn.ch>
Date:   Fri, 29 Jul 2022 00:11:16 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Oliver Neukum <oneukum@...e.com>
Cc:     hayeswang@...ltek.com, netdev@...r.kernel.org
Subject: Re: [RFC] r8152: pass through needs to be singular

On Thu, Jul 28, 2022 at 09:18:51PM +0200, Oliver Neukum wrote:
> If multiple devices are connected only one of them
> is allowed to get the pass through MAC

Is that true? Ethernet switches often use the same MAC address on
multiple ports. It is not inherently broken to have the same MAC
address on multiple interfaces.

We also need to watch out for regressions. There could be users who do
have the same MAC address on multiple interfaces, and it works for
them. With this change it is a 50/50 chance they no longer get the MAC
address they expect, depending on probe order.

We know this implementation of pass through it very broken, but
unfortunately, it is there, and we have to follow the normal
regression rules, even if we really would like to throw it all out.

What exactly is your problem which you are trying to fix? 

     Andrew