netdev - RE: handling MAC set by user space in reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <353a10d11f2345c8acff717be4ade74a@realtek.com>
Date:   Thu, 28 Jul 2022 08:40:16 +0000
From:   Hayes Wang <hayeswang@...ltek.com>
To:     Oliver Neukum <oneukum@...e.com>
CC:     USB list <linux-usb@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: handling MAC set by user space in reset_resume() of r8152

Oliver Neukum <oneukum@...e.com>
> > Date: Wed, 27 Jul 2022 13:29:42 +0200
> > Subject: [PATCH] r8152: restore external MAC in reset_resume
> >
> > If user space has set the MAC of the interface,
> > reset_resume() must restore that setting rather
> > than redetermine the MAC like if te interface
> > is probed regularly.

I think this patch conflicts with commit 25766271e42f ("r8152: Refresh
MAC address during USBDEVFS_RESET"). The results would be changed.

Besides, I don't understand why you set tp->external_mac = false
in rtl8152_down().

Best Regards,
Hayes