lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 29 Jul 2022 15:08:39 +0200 From: Andrew Lunn <andrew@...n.ch> To: "Pandey, Radhey Shyam" <radhey.shyam.pandey@....com> Cc: "michal.simek@...inx.com" <michal.simek@...inx.com>, "nicolas.ferre@...rochip.com" <nicolas.ferre@...rochip.com>, "claudiu.beznea@...rochip.com" <claudiu.beznea@...rochip.com>, "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>, "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>, "ronak.jain@...inx.com" <ronak.jain@...inx.com>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "git@...inx.com" <git@...inx.com>, "git (AMD-Xilinx)" <git@....com> Subject: Re: [PATCH net-next 2/2] net: macb: Add zynqmp SGMII dynamic configuration support > > > How robust is this? What if somebody specified a different power domain? > > > > Some background - init_reset_optional() fn is implemented for three > > platforms i.e., zynqmp, versal, MPFS. > > > > zynqmp_pm_set_gem_config API expect first argument as GEM node id so, > > power-domain DT property is passed to get node ID. > > > > However, power-domain property is read only if underlying firmware > > supports configuration of GEM secure space. It's only true for zynqmp SGMII > > case and for zynqmp power domain is fixed. > > In addition to it there is an error handling in power-domain property parsing. > > Hope this answers the question. > > Please let me know the implementation looks fine or needs any modification? Given that explanation, it looks fine. Reviewed-by: Andrew Lunn <andrew@...n.ch> Andrew
Powered by blists - more mailing lists