netdev - Re: [net v3 PATCH 3/5] octeontx2-af: Allow mkex profiles without dmac.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 30 Jul 2022 07:24:35 +0000
From:   Subbaraya Sundeep Bhatta <sbhatta@...vell.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Suman Ghosh <sumang@...vell.com>
Subject: Re: [net v3 PATCH 3/5] octeontx2-af: Allow mkex profiles without
 dmac.

Hi Jakub,

________________________________________
From: Jakub Kicinski <kuba@...nel.org>
Sent: Saturday, July 30, 2022 9:50 AM
To: Subbaraya Sundeep Bhatta
Cc: davem@...emloft.net; pabeni@...hat.com; edumazet@...gle.com; Sunil Kovvuri Goutham; netdev@...r.kernel.org; Suman Ghosh
Subject: Re: [net v3 PATCH 3/5] octeontx2-af: Allow mkex profiles without dmac.

----------------------------------------------------------------------
On Fri, 29 Jul 2022 21:13:48 +0530 Subbaraya Sundeep wrote:
> It is possible to have custom mkex profiles which do not extract
> DMAC into the key to free up space in the key and use it for L3
> or L4 packet fields. Current code bails out if DMAC extraction is
> not present in the key. This patch fixes it by allowing profiles
> without DMAC and also supports installing rules based on L2MB bit
> set by hardware for multicast and broadcast packets.
>
> This patch also adds debugging prints needed to identify profiles
> with wrong configuration.

I had some questions about whether this is regression fix or new
feature and the size of this patch - which do not seem to have been
addressed.

My bad, I totally missed looking your comment regd. feature or fix in v2.
You are right this should go as feature. I will drop this patch and send next spin.
I will send this patch alone later to net-next as a feature.

Thanks,
Sundeep