netdev - Re: [PATCH v2] net: tap: NULL pointer derefence in dev_parse_header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220729190307.667b4be0@kernel.org>
Date:   Fri, 29 Jul 2022 19:03:07 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc:     Cezar Bulinaru <cbulinaru@...il.com>, davem@...emloft.net,
        netdev@...r.kernel.org
Subject: Re: [PATCH v2] net: tap: NULL pointer derefence in
 dev_parse_header_protocol when skb->dev is null

On Fri, 29 Jul 2022 08:52:04 +0200 Willem de Bruijn wrote:
> >  drivers/net/tap.c                    |  21 +-
> >  tools/testing/selftests/net/Makefile |   2 +-
> >  tools/testing/selftests/net/tap.c    | 395 +++++++++++++++++++++++++++  
> 
> Is there prior art in mixing fixes and tests? Should the test go to
> net or always to net-next?

Not sure if there is any official guidance, but I usually put both 
together. Separate patches in the same series, targeting one tree.