netdev - Re: [PATCH net-next v3 1/3] net: Add a bhash2 table hashed by port + address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 1 Aug 2022 02:46:02 +0800
From:   kernel test robot <lkp@...el.com>
To:     Joanne Koong <joannelkoong@...il.com>, netdev@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, pabeni@...hat.com, edumazet@...gle.com,
        kuba@...nel.org, kafai@...com, davem@...emloft.net,
        Joanne Koong <joannelkoong@...il.com>
Subject: Re: [PATCH net-next v3 1/3] net: Add a bhash2 table hashed by port +
 address

Hi Joanne,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Joanne-Koong/Add-a-second-bind-table-hashed-by-port-address/20220723-035903
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 949d6b405e6160ae44baea39192d67b39cb7eeac
config: sh-randconfig-m041-20220722 (https://download.01.org/0day-ci/archive/20220801/202208010253.SjaFtOB8-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

smatch warnings:
include/net/inet_hashtables.h:265 inet_bhashfn_portaddr() warn: inconsistent indenting

vim +265 include/net/inet_hashtables.h

   253	
   254	static inline struct inet_bind_hashbucket *
   255	inet_bhashfn_portaddr(const struct inet_hashinfo *hinfo, const struct sock *sk,
   256			      const struct net *net, unsigned short port)
   257	{
   258		u32 hash;
   259	
   260	#if IS_ENABLED(CONFIG_IPV6)
   261		if (sk->sk_family == AF_INET6)
   262			hash = ipv6_portaddr_hash(net, &sk->sk_v6_rcv_saddr, port);
   263		else
   264	#endif
 > 265			hash = ipv4_portaddr_hash(net, sk->sk_rcv_saddr, port);
   266		return &hinfo->bhash2[hash & (hinfo->bhash_size - 1)];
   267	}
   268	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp