netdev - Re: [PATCH][next] tls: rx: Fix less than zero check on unsigned variable sz

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220801122459.57b7df02@kernel.org>
Date:   Mon, 1 Aug 2022 12:24:59 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Colin Ian King <colin.i.king@...il.com>
Cc:     Boris Pismenny <borisp@...dia.com>,
        John Fastabend <john.fastabend@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] tls: rx: Fix less than zero check on unsigned
 variable sz

On Sat, 30 Jul 2022 12:40:27 +0100 Colin Ian King wrote:
> Variable sz is declared as an unsigned size_t and is being checked
> for an less than zero error return on a call to tls_rx_msg_size.
> Fix this by making sz an int.
> 
> Fixes: 84c61fe1a75b ("tls: rx: do not use the standard strparser")
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>  net/tls/tls_strp.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Already fixed 2 days before you posted, I guess linux-next lagged.

commit 8fd1e151779285b211e7184e9237bba69bd74386
Author:     Yang Li <yang.lee@...ux.alibaba.com>
AuthorDate: Wed Jul 27 20:10:19 2022
Commit:     Jakub Kicinski <kuba@...nel.org>
CommitDate: Thu Jul 28 21:50:39 2022

    tls: rx: Fix unsigned comparison with less than zero