netdev - Re: [PATCH] net: txgbe: Fix an error handling path in txgbe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 1 Aug 2022 12:31:42 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     "Jiawen Wu" <jiawenwu@...stnetic.com>
Cc:     "'Christophe JAILLET'" <christophe.jaillet@...adoo.fr>,
        "'David S. Miller'" <davem@...emloft.net>,
        "'Eric Dumazet'" <edumazet@...gle.com>,
        "'Paolo Abeni'" <pabeni@...hat.com>,
        <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: txgbe: Fix an error handling path in txgbe_probe()

On Mon, 1 Aug 2022 10:54:44 +0800 Jiawen Wu wrote:
> On Monday, August 1, 2022 12:34 AM, Christophe wrote:
> > A pci_enable_pcie_error_reporting() should be balanced by a corresponding
> > pci_disable_pcie_error_reporting() call in the error handling path, as already
> > done in the remove function.
> 
> Thanks Christophe, it's right.
> Reviewed-by: Jiawen Wu <jiawenwu@...stnetic.com>

Your reply did not make it to the list:
https://lore.kernel.org/r/02a101d8a552$0e704650$2b50d2f0$@trustnetic.com+898582B7F010EAA4/
not sure why but I wanted to let you know.

Thanks for reviewing the fix promptly!