netdev - Re: [PATCH v3 2/2] selftests: add few test cases for tap driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+FuTScdwmfpzoJw_YGcPZ0kYogktKy=BK+axjybxkE43wWnjA@mail.gmail.com>
Date:   Mon, 1 Aug 2022 10:22:33 +0200
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Cezar Bulinaru <cbulinaru@...il.com>
Cc:     davem@...emloft.net, kuba@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v3 2/2] selftests: add few test cases for tap driver

On Mon, Aug 1, 2022 at 6:57 AM Cezar Bulinaru <cbulinaru@...il.com> wrote:
>
> Few test cases related to the fix for 924a9bc362a5:
> "net: check if protocol extracted by virtio_net_hdr_set_proto is correct"
>
> Need test for the case when a non-standard packet (GSO without NEEDS_CSUM)
> sent to the tap device causes a BUG check in the tap driver.
>
> Signed-off-by: Cezar Bulinaru <cbulinaru@...il.com>

Thanks a lot for adding initial tap tests.

It is still missing .gitignore.

> +FIXTURE_TEARDOWN(tap)
> +{
> +       int ret;
> +
> +       if (self->fd != -1)
> +               close(self->fd);
> +
> +       ret = dev_delete(param_dev_dummy_name);
> +       EXPECT_EQ(ret, 0);
> +
> +       ret = dev_delete(param_dev_tap_name);
> +       EXPECT_EQ(ret, 0);

Should this remove the tap device before removing the dummy device?