netdev - Re: [PATCH net-next] net/tls: Use RCU API to access tls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 2 Aug 2022 08:38:26 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Maxim Mikityanskiy <maximmi@...dia.com>
Cc:     "davem@...emloft.net" <davem@...emloft.net>,
        Tariq Toukan <tariqt@...dia.com>,
        Gal Pressman <gal@...dia.com>,
        "john.fastabend@...il.com" <john.fastabend@...il.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        Saeed Mahameed <saeedm@...dia.com>,
        Boris Pismenny <borisp@...dia.com>
Subject: Re: [PATCH net-next] net/tls: Use RCU API to access tls_ctx->netdev

On Tue, 2 Aug 2022 12:07:18 +0000 Maxim Mikityanskiy wrote:
> > Oops, looks like we also got some new sparse warnings from this:
> > 
> > 2 new warnings in drivers/net/bonding/bond_main.c
> > 1 new warning  in drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c  
> 
> Looks like neither me, nor our internal CI built these files - sorry!
> I'll fix these and look for the usages more carefully.
> 
> BTW, the bonding case misses even the READ_ONCE, so it's an existing
> bug, exposed by the transition to the proper RCU API in my patch.

Nice! You can slap a fixes tag on it, for accounting purposes, and stick
to net-next in the subject, tree doesn't matter right now.