netdev - Re: [PATCH v2] net: gro: skb_gro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220802122844.56ddafd8@kernel.org>
Date:   Tue, 2 Aug 2022 12:28:44 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Richard Gobert <richardbgobert@...il.com>
Cc:     davem@...emloft.net, pabeni@...hat.com, yoshfuji@...ux-ipv6.org,
        dsahern@...nel.org, xeb@...l.ru, edumazet@...gle.com,
        roopa@...dia.com, bigeasy@...utronix.de, iwienand@...hat.com,
        heikki.krogerus@...ux.intel.com, arnd@...db.de,
        netdev@...r.kernel.org
Subject: Re: [PATCH v2] net: gro: skb_gro_header helper function

On Tue, 2 Aug 2022 16:38:02 +0200 Richard Gobert wrote:
> Introduce a simple helper function to replace a common pattern.
> When accessing the GRO header, we fetch the pointer from frag0,
> then test its validity and fetch it from the skb when necessary.
> 
> This leads to the pattern
> skb_gro_header_fast -> skb_gro_header_hard -> skb_gro_header_slow
> recurring many times throughout GRO code.
> 
> This patch replaces these patterns with a single inlined function
> call, improving code readability.
> 
> Signed-off-by: Richard Gobert <richardbgobert@...il.com>

# Form letter - net-next is closed

The merge window for Linux 6.0 has started and therefore 
net-next is closed for new drivers, features, code refactoring 
and optimizations. We are currently accepting bug fixes only.

Please repost when net-next reopens after 6.0-rc1 is cut.

RFC patches sent for review only are obviously welcome at any time.