netdev - Re: [PATCH net-next v1 02/10] net: dsa: microchip: allow to pass return values for PHY read/write accesses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 2 Aug 2022 14:19:02 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Oleksij Rempel <o.rempel@...gutronix.de>
Cc:     Woojung Huh <woojung.huh@...rochip.com>,
        UNGLinuxDriver@...rochip.com, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, kernel@...gutronix.de,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v1 02/10] net: dsa: microchip: allow to pass
 return values for PHY read/write accesses

On Fri, Jul 29, 2022 at 03:03:38PM +0200, Oleksij Rempel wrote:
> PHY access may end with errors on different levels. So, allow to forward
> return values where possible.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> ---
> -void ksz8_w_phy(struct ksz_device *dev, u16 phy, u16 reg, u16 val)
> +int ksz8_w_phy(struct ksz_device *dev, u16 phy, u16 reg, u16 val)
>  {
>  	u8 restart, speed, ctrl, data;
>  	const u16 *regs;
> @@ -787,6 +789,9 @@ void ksz8_w_phy(struct ksz_device *dev, u16 phy, u16 reg, u16 val)
>  	default:
>  		break;
>  	}
> +
> +

Too many empty lines.

> +	return 0;
>  }