netdev - Re: [PATCH net-next v1 04/10] net: dsa: microchip: ksz9477: add error handling to ksz9477_r/w

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220802112430.7e7kpoqqlvxqrflf@skbuf>
Date:   Tue, 2 Aug 2022 14:24:30 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Oleksij Rempel <o.rempel@...gutronix.de>
Cc:     Woojung Huh <woojung.huh@...rochip.com>,
        UNGLinuxDriver@...rochip.com, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, kernel@...gutronix.de,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v1 04/10] net: dsa: microchip: ksz9477: add
 error handling to ksz9477_r/w_phy

On Fri, Jul 29, 2022 at 03:03:40PM +0200, Oleksij Rempel wrote:
>  	} else {
> -		ksz_pread16(dev, addr, 0x100 + (reg << 1), &val);
> +		ret = ksz_pread16(dev, addr, 0x100 + (reg << 1), &val);
> +		if (ret)
> +			return ret;
> +
>  		ksz9477_r_phy_quirks(dev, addr, reg, &val);
>  	}
>  
> @@ -340,11 +344,9 @@ int ksz9477_w_phy(struct ksz_device *dev, u16 addr, u16 reg, u16 val)
>  
>  	/* No gigabit support.  Do not write to this register. */
>  	if (!(dev->features & GBIT_SUPPORT) && reg == MII_CTRL1000)
> -		return 0;
> +		return -ENOTSUPP;

I wonder if ENOTSUPP is the most appropriate error code, given that I
see it defined under a comment "Defined for the NFSv3 protocol".
How about -ENXIO?

>  
> -	ksz_pwrite16(dev, addr, 0x100 + (reg << 1), val);
> -
> -	return 0;
> +	return ksz_pwrite16(dev, addr, 0x100 + (reg << 1), val);
>  }
>  
>  void ksz9477_cfg_port_member(struct ksz_device *dev, int port, u8 member)
> -- 
> 2.30.2
>