netdev - Re: [PATCH v2 net 0/4] Do not use RT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220803112732.GB29408@pc-4.home>
Date:   Wed, 3 Aug 2022 13:27:32 +0200
From:   Guillaume Nault <gnault@...hat.com>
To:     Matthias May <matthias.may@...termo.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, roopa@...dia.com,
        eng.alaamohamedsoliman.am@...il.com, bigeasy@...utronix.de,
        saeedm@...dia.com, leon@...nel.org, roid@...dia.com,
        maord@...dia.com, lariel@...dia.com, vladbu@...dia.com,
        cmi@...dia.com, yoshfuji@...ux-ipv6.org, dsahern@...nel.org,
        linux-kernel@...r.kernel.org, bpf@...r.kernel.org,
        linux-rdma@...r.kernel.org, nicolas.dichtel@...nd.com,
        eyal.birger@...il.com, jesse@...ira.com, linville@...driver.com,
        daniel@...earbox.net, hadarh@...lanox.com, ogerlitz@...lanox.com,
        willemb@...gle.com, martin.varghese@...ia.com
Subject: Re: [PATCH v2 net 0/4] Do not use RT_TOS for IPv6 flowlabel

On Tue, Aug 02, 2022 at 02:09:31PM +0200, Matthias May wrote:
> According to Guillaume Nault RT_TOS should never be used for IPv6.
> 
> Quote:
> RT_TOS() is an old macro used to interprete IPv4 TOS as described in
> the obsolete RFC 1349. It's conceptually wrong to use it even in IPv4
> code, although, given the current state of the code, most of the
> existing calls have no consequence.
> 
> But using RT_TOS() in IPv6 code is always a bug: IPv6 never had a "TOS"
> field to be interpreted the RFC 1349 way. There's no historical
> compatibility to worry about.

Apart from the not so informative commit messages, I'm fine with this
series. Please keep my acked-by on all patches if you send a v3.

Thanks again for fixing this.

Acked-by: Guillaume Nault <gnault@...hat.com>

> ---
> v1 -> v2:
>  - Fix spacing of "Fixes" tag.
>  - Add missing CCs
> 
> Matthias May (4):
>   geneve: do not use RT_TOS for IPv6 flowlabel
>   vxlan: do not use RT_TOS for IPv6 flowlabel
>   mlx5: do not use RT_TOS for IPv6 flowlabel
>   ipv6: do not use RT_TOS for IPv6 flowlabel
> 
>  drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c | 4 ++--
>  drivers/net/geneve.c                                | 3 +--
>  drivers/net/vxlan/vxlan_core.c                      | 2 +-
>  net/ipv6/ip6_output.c                               | 3 +--
>  4 files changed, 5 insertions(+), 7 deletions(-)
> 
> -- 
> 2.35.1
>