netdev - Re: [RFC 1/1] net: move IFF_LIVE_ADDR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6b0d571ea5fbc5942d798d5201b2cef253688949.camel@gmail.com>
Date:   Thu, 04 Aug 2022 12:29:11 -0700
From:   James Prestwood <prestwoj@...il.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org
Subject: Re: [RFC 1/1] net: move IFF_LIVE_ADDR_CHANGE to public flag

Hi,

On Thu, 2022-08-04 at 10:59 -0700, Stephen Hemminger wrote:
> On Thu,  4 Aug 2022 10:43:07 -0700
> James Prestwood <prestwoj@...il.com> wrote:
> 
> > + * @IFF_LIVE_ADDR_CHANGE: device supports hardware address
> > + *     change when it's running. Volatile
> 
> Since this is a property of the device driver, why is it volatile?

Its not intended to be changed since its a device capability.

> When you make it part of uapi, you also want to restrict userspace
> from changing the value via sysfs?
> 

Yeah, this is what I intended to do. Similar to the other volatile
options. Basically following this comment:

"...few flags can be toggled and some other flags are always preserved
from the original net_device flags even if you try to set them via
sysfs. Flags which are always preserved are kept under the flag
grouping @IFF_VOLATILE. Flags which are volatile are annotated below as
such."

Thanks,
James