netdev - Re: [RFC] r8152: pass through needs to be singular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0c27917c-572a-7e70-3512-9357fabb458a@suse.com>
Date:   Thu, 4 Aug 2022 10:57:53 +0200
From:   Oliver Neukum <oneukum@...e.com>
To:     Hayes Wang <hayeswang@...ltek.com>,
        Oliver Neukum <oneukum@...e.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [RFC] r8152: pass through needs to be singular



On 03.08.22 05:48, Hayes Wang wrote:
> Oliver Neukum <oneukum@...e.com>
>> Sent: Friday, July 29, 2022 3:19 AM
> [...]
>> @@ -1608,6 +1622,12 @@ static int vendor_mac_passthru_addr_read(struct
>> r8152 *tp, struct sockaddr *sa)
>>  	acpi_object_type mac_obj_type;
>>  	int mac_strlen;
>>
>> +	mutex_lock(&pass_through_lock);
>> +
>> +	if (!holder_of_pass_through) {
>> +		ret = -EBUSY;
>> +		goto failout;
>> +	}
> 
> Excuse me. I have one question.
> When is the holder_of_pass_through set?
> The default value of holder_of_pass_through is NULL, so
> it seems the holder_of_pass_through would never be set.


Hi,

here in vendor_mac_passthru_addr_read()

>>  amacout:
>>  	kfree(obj);
>> +failout:
>> +	if (!ret)
>> +		holder_of_pass_through = tp;
>> +	mutex_unlock(&pass_through_lock);
>>  	return ret;
>>  }

	Regards
		Oliver