netdev - Re: [PATCH ipsec 1/3] Revert "xfrm: update SA curlft.use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220804093114.GS2950045@gauss3.secunet.de>
Date:   Thu, 4 Aug 2022 11:31:14 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Antony Antony <antony.antony@...unet.com>
CC:     Herbert Xu <herbert@...dor.apana.org.au>,
        <0002-xfrm-fix-XFRMA_LASTUSED-comment.patch@...n.secunet.de>,
        <0003-xfrm-clone-missing-x-lastused-in-xfrm_do_migrate.patch@...n.secunet.de>,
        <netdev@...r.kernel.org>, Tobias Brunner <tobias@...ongswan.org>
Subject: Re: [PATCH ipsec 1/3] Revert "xfrm: update SA curlft.use_time"

On Wed, Jul 27, 2022 at 05:38:35PM +0200, Antony Antony wrote:
> This reverts commit af734a26a1a95a9fda51f2abb0c22a7efcafd5ca.
> 
> The abvoce commit is a regression according RFC 2367. A better fix would be
> use x->lastused. Which will be propsed later.
> 
> according to RFC 2367 use_time == sadb_lifetime_usetime.
> 
> "sadb_lifetime_usetime
>                    For CURRENT, the time, in seconds, when association
>                    was first used. For HARD and SOFT, the number of
>                    seconds after the first use of the association until
>                    it expires."
> 
> Fixes: af734a26a1a9 ("xfrm: update SA curlft.use_time")
> Signed-off-by: Antony Antony <antony.antony@...unet.com>

Series applied, thanks Antony!