netdev - Re: [RFC] r8152: pass through needs to be singular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3017563c-0085-ae88-1ef0-40d1f89ef4c5@suse.com>
Date:   Thu, 4 Aug 2022 15:29:40 +0200
From:   Oliver Neukum <oneukum@...e.com>
To:     Andrew Lunn <andrew@...n.ch>, Oliver Neukum <oneukum@...e.com>
Cc:     hayeswang@...ltek.com, netdev@...r.kernel.org
Subject: Re: [RFC] r8152: pass through needs to be singular

On 04.08.22 15:24, Andrew Lunn wrote:

> The problem is regressions. Current code will put the MAC address on
> both. I guess most users just have one dock with a cabled and the
> second is unused. Both will get the same MAC address, the DHCP server
> will recognise the MAC address and give out the expected IP address.

1. That is a rather esoteric situation in which a bug is exploited
2. We are at a philosophical point where I need to argue that fixing
a bug is necessarily a change in behavior.

> I would expect whatever MAC address is in the netdev structure to be
> put on the interface at resume. That should of been the MAC it was
> using before suspend. And by doing that, you bypass all the discussion
> about where it came from.

Debatable, but that's not what the driver does. It reacquires the MAC
from the firmware. I want to change that. Though obviously that changes
behavior.

I am sorry, but at some point a bug is a bug, even if some people like
it.

	Regards
		Oliver