netdev - Re: [PATCH v5 net] net: tap: NULL pointer derefence in dev_parse_header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 05 Aug 2022 08:00:14 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     c b <cbulinaru@...il.com>
Cc:     davem@...emloft.net, kuba@...nel.org, willemb@...gle.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH v5 net] net: tap: NULL pointer derefence in
 dev_parse_header_protocol when skb->dev is null

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@...emloft.net>:

On Wed,  3 Aug 2022 02:27:59 -0400 you wrote:
> Fixes a NULL pointer derefence bug triggered from tap driver.
> When tap_get_user calls virtio_net_hdr_to_skb the skb->dev is null
> (in tap.c skb->dev is set after the call to virtio_net_hdr_to_skb)
> virtio_net_hdr_to_skb calls dev_parse_header_protocol which
> needs skb->dev field to be valid.
> 
> The line that trigers the bug is in dev_parse_header_protocol
> (dev is at offset 0x10 from skb and is stored in RAX register)
>   if (!dev->header_ops || !dev->header_ops->parse_protocol)
>   22e1:   mov    0x10(%rbx),%rax
>   22e5:	  mov    0x230(%rax),%rax
> 
> [...]

Here is the summary with links:
  - [v5,net] net: tap: NULL pointer derefence in dev_parse_header_protocol when skb->dev is null
    https://git.kernel.org/netdev/net/c/4f61f133f354

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html