netdev - Re: [PATCH net] net/mlx5e: Fix use after free in mlx5e_fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220805062141.GG3438@kadam>
Date:   Fri, 5 Aug 2022 09:21:41 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Tariq Toukan <ttoukan.linux@...il.com>
Cc:     Leon Romanovsky <leon@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Tariq Toukan <tariqt@...dia.com>, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Lama Kayal <lkayal@...dia.com>,
        Saeed Mahameed <saeedm@...dia.com>
Subject: Re: [PATCH net] net/mlx5e: Fix use after free in mlx5e_fs_init()

On Thu, Aug 04, 2022 at 06:04:52PM +0300, Tariq Toukan wrote:
> 
> 
> On 8/4/2022 5:43 PM, Dan Carpenter wrote:
> > Call mlx5e_fs_vlan_free(fs) before kvfree(fs).
> > 
> > Fixes: af8bbf730068 ("net/mlx5e: Convert mlx5e_flow_steering member of mlx5e_priv to pointer")
> > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> > ---
> > This applies to net but I never really understand how mellanox patches
> > work...
> > 
> 
> Hi Dan,
> This patch belongs to next kernel (6.0).
> It seems that net-next (or parts of it) is already merged into net as we're
> in the merge window.

Right.  But commit af8bbf730068 was merged by Saeed.  I think that went
through his tree and then pulled into one of the networking trees.  But
sometimes these patches are pulled directly into a networking tree.

I can't remember how it works, but it's somehow my job to remember this
stuff for 200+ *hundred* different friggin git trees and put the tree
name in the subject.  :P  (small rant).

> 
> Reviewed-by: Tariq Toukan <tariqt@...dia.com>

Thanks!

regards,
dan carpenter