netdev - Re: [PATCH net] net: usb: ax88179_178a have issues with FLAG_SEND

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 5 Aug 2022 20:26:46 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Jose Alonso <joalonsof@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>, stable <stable@...r.kernel.org>,
        Ronald Wahl <ronald.wahl@...itan.com>
Subject: Re: [PATCH net] net: usb: ax88179_178a have issues with FLAG_SEND_ZLP

On Fri, Aug 05, 2022 at 03:08:40PM -0300, Jose Alonso wrote:
> The usage of FLAG_SEND_ZLP causes problems to other firmware/hardware versions
> that have no issues.
> 
> This patch is reverting 36a15e1cb134 ("net: usb: ax88179_178a needs FLAG_SEND_ZLP")
> because using FLAG_SEND_ZLP in this context is not safe.
> See:
> https://patchwork.ozlabs.org/project/netdev/patch/1270599787.8900.8.camel@Linuxdev4-laptop/#118378

Please wrap (but not the url) at 72 columns like your editor asked you
to :)

> 
> reported by:
> Ronald Wahl <ronald.wahl@...itan.com>

Should be:

Reported-by: Ronald Wahl <ronald.wahl@...itan.com>

> https://bugzilla.kernel.org/show_bug.cgi?id=216327
> https://bugs.archlinux.org/task/75491

Those should be "Link:" references.

And you need a cc: stable and/or a "Fixes:" tag please.

Also there is a normal template that 'git revert' gives you, why not use
that?

thanks,

greg k-h