lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 5 Aug 2022 13:18:22 -0700 From: Jacob Keller <jacob.e.keller@...el.com> To: Jiri Pirko <jiri@...dia.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> Subject: cmd_sb_occ_show doesn't call dl_put_opts Hey Jiri, I noticed while looking at implementing policy checking support in devlink that the cmd_sb_occ_show calls dl_argv_parse but then doesn't call dl_put_opts, so it doesn't seem to be sending any of the attributes down to the kernel. I am guessing this is not done on purpose, and is just an oversight, caused by needing to send two different netlink messages. It looks like the code could use a dl_argc check to determine whether to use NLM_F_DUMP and call dl_put_opts to ensure the netlink attributes get added..? Thanks, Jake
Powered by blists - more mailing lists