netdev - Re: [PATCH v2 net] net: usb: ax88179_178a have issues with FLAG_SEND

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220805175155.6f021ff4@kernel.org>
Date:   Fri, 5 Aug 2022 17:51:55 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jose Alonso <joalonsof@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        netdev <netdev@...r.kernel.org>, stable <stable@...r.kernel.org>,
        Ronald Wahl <ronald.wahl@...itan.com>
Subject: Re: [PATCH v2 net] net: usb: ax88179_178a have issues with
 FLAG_SEND_ZLP

On Fri, 05 Aug 2022 17:27:33 -0300 Jose Alonso wrote:
> To: David S. Miller <davem@...emloft.net>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: netdev <netdev@...r.kernel.org>, stable <stable@...r.kernel.org>, Ronald Wahl <ronald.wahl@...itan.com>
> 
>     [PATCH net] net: usb: ax88179_178a have issues with FLAG_SEND_ZLP
>     The usage of FLAG_SEND_ZLP causes problems to other firmware/hardware
>     versions that have no issues.

But you tested with 1790 previously so isn't the misbehaviour on that
device going to come back if we remove the flag again?

>     The FLAG_SEND_ZLP is not safe to use in this context.
>     See:
>     https://patchwork.ozlabs.org/project/netdev/patch/1270599787.8900.8.camel@Linuxdev4-laptop/#118378
>     
>     Reported-by: Ronald Wahl <ronald.wahl@...itan.com>
>     Link: https://bugzilla.kernel.org/show_bug.cgi?id=216327
>     Link: https://bugs.archlinux.org/task/75491
>     
>     Fixes: 36a15e1cb134 ("net: usb: ax88179_178a needs FLAG_SEND_ZLP")
>     Signed-off-by: Jose Alonso <joalonsof@...il.com>

The commit message looks unnecessarily indented, could you try with git
format-patch / git send-email?