lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 5 Aug 2022 18:45:04 -0700 From: Jakub Kicinski <kuba@...nel.org> To: Alexandra Winter <wintera@...ux.ibm.com> Cc: David Miller <davem@...emloft.net>, Andrew Lunn <andrew@...n.ch>, netdev@...r.kernel.org, linux-s390@...r.kernel.org, Heiko Carstens <hca@...ux.ibm.com>, Thorsten Winkler <twinkler@...ux.ibm.com> Subject: Re: [PATCH net v2] s390/qeth: cache link_info for ethtool On Fri, 5 Aug 2022 17:57:14 +0200 Alexandra Winter wrote: > Since > commit e6e771b3d897 ("s390/qeth: detach netdevice while card is offline") > there was a timing window during recovery, that qeth_query_card_info could > be sent to the card, even before it was ready for it, leading to a failing > card recovery. There is evidence that this window was hit, as not all > callers of get_link_ksettings() check for netif_device_present. > > Use cached values in qeth_get_link_ksettings(), instead of calling > qeth_query_card_info() and falling back to default values in case it > fails. Link info is already updated when the card goes online, e.g. after > STARTLAN (physical link up). Set the link info to default values, when the > card goes offline or at STOPLAN (physical link down). A follow-on patch > will improve values reported for link down. > > Fixes: e6e771b3d897 ("s390/qeth: detach netdevice while card is offline") > > Signed-off-by: Alexandra Winter <wintera@...ux.ibm.com> > Reviewed-by: Thorsten Winkler <twinkler@...ux.ibm.com> Ah, looks like you figured out what my confusion was and squashed the patches :) That works, too.
Powered by blists - more mailing lists