lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 7 Aug 2022 22:07:09 -0700
From:   Evan Green <>
To:     "Guilherme G. Piccoli" <>
Cc:     Andrew Morton <>,,
        Petr Mladek <>,,
        LKML <>,,,,,,,,,
        Andy Shevchenko <>,
        Arnd Bergmann <>, Borislav Petkov <>,
        Jonathan Corbet <>,,,,,
        Greg Kroah-Hartman <>,,,,,
        Kees Cook <>,,,,,,,, Alan Stern <>,
        Thomas Gleixner <>,,, Will Deacon <>,, Ard Biesheuvel <>,
        David Gow <>,
        Julius Werner <>
Subject: Re: [PATCH v2 03/13] firmware: google: Test spinlock on panic path to
 avoid lockups

On Tue, Jul 19, 2022 at 12:55 PM Guilherme G. Piccoli
<> wrote:
> Currently the gsmi driver registers a panic notifier as well as
> reboot and die notifiers. The callbacks registered are called in
> atomic and very limited context - for instance, panic disables
> preemption and local IRQs, also all secondary CPUs (not executing
> the panic path) are shutdown.
> With that said, taking a spinlock in this scenario is a dangerous
> invitation for lockup scenarios. So, fix that by checking if the
> spinlock is free to acquire in the panic notifier callback - if not,
> bail-out and avoid a potential hang.
> Fixes: 74c5b31c6618 ("driver: Google EFI SMI")
> Cc: Ard Biesheuvel <>
> Cc: David Gow <>
> Cc: Evan Green <>
> Cc: Julius Werner <>
> Signed-off-by: Guilherme G. Piccoli <>

Reviewed-by: Evan Green <>

Powered by blists - more mailing lists