lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20220808075640.5it462iozqgecxih@sgarzare-redhat> Date: Mon, 8 Aug 2022 09:56:40 +0200 From: Stefano Garzarella <sgarzare@...hat.com> To: Peilin Ye <yepeilin.cs@...il.com> Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Peilin Ye <peilin.ye@...edance.com>, George Zhang <georgezhang@...are.com>, Dmitry Torokhov <dtor@...are.com>, Andy King <acking@...are.com>, virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH net v2 2/2] vsock: Set socket state back to SS_UNCONNECTED in vsock_connect_timeout() On Sun, Aug 07, 2022 at 02:00:46AM -0700, Peilin Ye wrote: >From: Peilin Ye <peilin.ye@...edance.com> > >Imagine two non-blocking vsock_connect() requests on the same socket. >The first request schedules @connect_work, and after it times out, >vsock_connect_timeout() sets *sock* state back to TCP_CLOSE, but keeps >*socket* state as SS_CONNECTING. > >Later, the second request returns -EALREADY, meaning the socket "already >has a pending connection in progress", even if the first request has >already timed out. > >As suggested by Stefano, fix it by setting *socket* state back to >SS_UNCONNECTED, so that the second request will return -ETIMEDOUT. > >Suggested-by: Stefano Garzarella <sgarzare@...hat.com> >Fixes: d021c344051a ("VSOCK: Introduce VM Sockets") >Signed-off-by: Peilin Ye <peilin.ye@...edance.com> >--- >(new patch in v2) Thanks for sending this :-) Reviewed-by: Stefano Garzarella <sgarzare@...hat.com>
Powered by blists - more mailing lists