netdev - Re: pull request: bluetooth 2022-08-05

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABBYNZLe1rrvstMTXQ_YQxE9dgEwnemYmi21n6BnOEFaWW_zGA@mail.gmail.com>
Date:   Mon, 8 Aug 2022 17:08:45 -0700
From:   Luiz Augusto von Dentz <luiz.dentz@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     David Miller <davem@...emloft.net>,
        "linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
        "open list:NETWORKING [GENERAL]" <netdev@...r.kernel.org>
Subject: Re: pull request: bluetooth 2022-08-05

Hi Jakub,

On Mon, Aug 8, 2022 at 4:46 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Mon, 8 Aug 2022 14:51:00 -0700 Luiz Augusto von Dentz wrote:
> > Is there a script or something which can be used to verify the Fix
> > tags? Or you can actually tell me what are the hashes that appear not
> > to be on net.
>
> Yes:
>
> https://raw.githubusercontent.com/gregkh/gregkh-linux/master/work/verify_fixes.sh

Perfect, looks like I missed 2 but the script find them out:

Commit: 4896e034bdd1 ("Bluetooth: ISO: Fix memory corruption")
    Fixes tag: Fixes: f764a6c2c1e4: ("Bluetooth: ISO: Add broadcast support")
    Has these problem(s):
        - missing space between the SHA1 and the subject
        - Subject does not match target commit subject
          Just use
            git log -1 --format='Fixes: %h ("%s")'
Commit: 25d6bec1685d ("Bluetooth: L2CAP: Fix l2cap_global_chan_by_psm
regression")
    Fixes tag: Fixes: d0be8347c623: ("Bluetooth: L2CAP: Fix
use-after-free caused by l2cap_chan_put")
    Has these problem(s):
        - missing space between the SHA1 and the subject
        - Subject does not match target commit subject
          Just use
            git log -1 --format='Fixes: %h ("%s")'

I fixed those and it now comes empty which I guess is what we expect.

-- 
Luiz Augusto von Dentz