netdev - Re: [RFC PATCH v3 net-next 02/10] dt-bindings: net: dsa: hellcreek: add missing CPU port phy-mode/fixed-link to example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220809201135.GA2312015-robh@kernel.org>
Date:   Tue, 9 Aug 2022 14:11:35 -0600
From:   Rob Herring <robh@...nel.org>
To:     Vladimir Oltean <vladimir.oltean@....com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Vladimir Oltean <olteanv@...il.com>,
        Marek Behún <kabel@...nel.org>,
        DENG Qingfang <dqfext@...il.com>,
        linux-renesas-soc@...r.kernel.org,
        Claudiu Manoil <claudiu.manoil@....com>,
        Landen Chao <Landen.Chao@...iatek.com>,
        devicetree@...r.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        George McCollister <george.mccollister@...il.com>,
        Clément Léger <clement.leger@...tlin.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        John Crispin <john@...ozen.org>,
        Kurt Kanzenbach <kurt@...utronix.de>,
        Woojung Huh <woojung.huh@...rochip.com>,
        Luiz Angelo Daros de Luca <luizluca@...il.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Aleksander Jan Bajkowski <olek2@...pl>,
        UNGLinuxDriver@...rochip.com, Marek Vasut <marex@...x.de>,
        Alvin Šipraga <alsi@...g-olufsen.dk>,
        Arun Ramadoss <arun.ramadoss@...rochip.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Oleksij Rempel <linux@...pel-privat.de>,
        Hauke Mehrtens <hauke@...ke-m.de>,
        Mans Rullgard <mans@...sr.com>,
        Russell King <rmk+kernel@...linux.org.uk>,
        Andrew Lunn <andrew@...n.ch>, Jakub Kicinski <kuba@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Sean Wang <sean.wang@...iatek.com>, netdev@...r.kernel.org,
        Pawel Dembicki <paweldembicki@...il.com>,
        Marcin Wojtas <mw@...ihalf.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Christian Marangi <ansuelsmth@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [RFC PATCH v3 net-next 02/10] dt-bindings: net: dsa: hellcreek:
 add missing CPU port phy-mode/fixed-link to example

On Sat, 06 Aug 2022 17:10:51 +0300, Vladimir Oltean wrote:
> Looking at hellcreek_phylink_get_caps(), I see that depending on whether
> is_100_mbits is set, speeds of 1G or of 100M will be advertised. The
> de1soc_r1_pdata sets is_100_mbits to true.
> 
> The PHY modes declared in the capabilities are MII, RGMII and GMII. GMII
> doesn't support 100Mbps, and as for RGMII, it would be a bit implausible
> to me to support this PHY mode but limit it to only 25 MHz. So I've
> settled on MII as a phy-mode in the example, and a fixed-link of
> 100Mbps.
> 
> As a side note, there exists such a thing as "rev-mii", because the MII
> protocol is asymmetric, and "mii" is the designation for the MAC side
> (expected to be connected to a PHY), and "rev-mii" is the designation
> for the PHY side (expected to be connected to a MAC). I wonder whether
> "mii" or "rev-mii" should actually be used here, since this is a CPU
> port and presumably connected to another MAC.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> ---
> v2->v3: patch is new
> 
>  .../devicetree/bindings/net/dsa/hirschmann,hellcreek.yaml   | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

Acked-by: Rob Herring <robh@...nel.org>