lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 9 Aug 2022 14:37:22 +0200
From:   Rasmus Villemoes <>
To:     Yury Norov <>,,
        Alexander Lobakin <>,
        Alexei Starovoitov <>,
        Alexey Klimov <>,
        Andrew Morton <>,
        Andrii Nakryiko <>,
        Andy Shevchenko <>,
        Ben Segall <>,
        Christoph Lameter <>,
        Dan Williams <>,
        Daniel Borkmann <>,
        Daniel Bristot de Oliveira <>,
        Dennis Zhou <>,
        Dietmar Eggemann <>,
        Eric Dumazet <>,
        Frederic Weisbecker <>,
        Guenter Roeck <>,
        Ingo Molnar <>,
        Isabella Basso <>,
        John Fastabend <>,
        Josh Poimboeuf <>,
        Juergen Gross <>,
        Juri Lelli <>,
        KP Singh <>,
        Kees Cook <>,
        Martin KaFai Lau <>,
        Mel Gorman <>, Miroslav Benes <>,
        Nathan Chancellor <>,
        "Paul E . McKenney" <>,
        Peter Zijlstra <>,
        Randy Dunlap <>,
        Sebastian Andrzej Siewior <>,
        Song Liu <>,
        Steven Rostedt <>,
        Tejun Heo <>,
        Thomas Gleixner <>,
        Valentin Schneider <>,
        Vincent Guittot <>,
        Vlastimil Babka <>, Yonghong Song <>,,,
Subject: Re: [PATCH 03/16] lib/test_bitmap: don't test bitmap_set if nbits ==

On 18/07/2022 21.28, Yury Norov wrote:
> Don't test bitmap_set(bitmap, start, 0) as it's useless, most probably
> a sign of error in real code, 

No it's not. The nbits can easily be the result of some computation that
ended up resulting in 0 being the right number to copy (or set, or
whatnot), and it's not unreasonable to _not_ check in the caller for
that special case, but rather rely on bitmap_set() to behave sanely - it
has perfectly well-defined semantics to "set 0 bits starting at @start".

The same way that memset() and memcpy() and memcmp() and countless other
functions have perfectly well-defined semantics with a length of 0, and
we don't add caller-side checks for those either.

NAK on this series.


Powered by blists - more mailing lists