netdev - Re: [PATCH net-next 2/3] sfc: support PTP over IPv6/UDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51e81ce8-38c9-3721-a8bb-eede3525f65c@gmail.com>
Date:   Tue, 9 Aug 2022 14:21:56 +0100
From:   Edward Cree <ecree.xilinx@...il.com>
To:     Íñigo Huguet <ihuguet@...hat.com>,
        habetsm.xilinx@...il.com
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/3] sfc: support PTP over IPv6/UDP

On 09/08/2022 10:20, Íñigo Huguet wrote:
> @@ -1297,28 +1299,46 @@ static void efx_ptp_remove_multicast_filters(struct efx_nic *efx)
>  	}
>  }
>  
> -static int efx_ptp_insert_ipv4_filter(struct efx_nic *efx, __be16 port)
> +static inline void efx_ptp_init_filter(struct efx_nic *efx,
> +				       struct efx_filter_spec *rxfilter)
>  {
> -	struct efx_ptp_data *ptp = efx->ptp_data;
> -	struct efx_filter_spec rxfilter;
> -	int rc;
> -
> -	efx_filter_init_rx(&rxfilter, EFX_FILTER_PRI_REQUIRED, 0,
> -			   efx_rx_queue_index(
> -				   efx_channel_get_rx_queue(ptp->channel)));
> +	efx_filter_init_rx(rxfilter, EFX_FILTER_PRI_REQUIRED, 0,
> +			   efx_rx_queue_index(efx_channel_get_rx_queue(
> +					      efx->ptp_data->channel)));

This indentation is misleading, it makes it look as though
 efx->ptp_data->channel is an argument to efx_rx_queue_index().
Please just use a local (how about struct efx_rx_queue *?).

Otherwise looks good.

-ed