lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 10 Aug 2022 12:34:34 +0200
From:   Johannes Berg <>
To:     Jakub Kicinski <>,
Subject: Re: [PATCH net] genetlink: correct uAPI defines

On Tue, 2022-08-09 at 16:27 -0700, Jakub Kicinski wrote:
> Commit 50a896cf2d6f ("genetlink: properly support per-op policy dumping")
> seems to have copy'n'pasted things a little incorrectly.
> The #define CTRL_ATTR_MCAST_GRP_MAX should have stayed right
> after the previous enum. The new CTRL_ATTR_POLICY_* needs
> its own define for MAX and that max should not contain the
> superfluous _DUMP in the name.
> We probably can't do anything about the CTRL_ATTR_POLICY_DUMP_MAX
> any more, there's likely code which uses it. For consistency
> (*cough* codegen *cough*) let's add the correctly name define
> nonetheless.

Oops, yes, that all makes sense.

Reviewed-by: Johannes Berg <>


Powered by blists - more mailing lists