netdev - Re: [PATCH bpf-next v4] selftests: xsk: Update poll test cases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YvOtvgdSnOhUd9Po@boxer>
Date:   Wed, 10 Aug 2022 15:08:14 +0200
From:   Maciej Fijalkowski <maciej.fijalkowski@...el.com>
To:     Shibin Koikkara Reeny <shibin.koikkara.reeny@...el.com>
CC:     <bpf@...r.kernel.org>, <ast@...nel.org>, <daniel@...earbox.net>,
        <netdev@...r.kernel.org>, <magnus.karlsson@...el.com>,
        <bjorn@...nel.org>, <kuba@...nel.org>, <andrii@...nel.org>,
        <ciara.loftus@...el.com>
Subject: Re: [PATCH bpf-next v4] selftests: xsk: Update poll test cases

On Wed, Aug 03, 2022 at 02:43:54PM +0000, Shibin Koikkara Reeny wrote:
> Poll test case was not testing all the functionality
> of the poll feature in the testsuite. This patch
> update the poll test case which contain 2 testcases to

updates, contains, test cases

> test the RX and the TX poll functionality and additional
> 2 more testcases to check the timeout features of the

feature

> poll event.
> 
> Poll testsuite have 4 test cases:

test suite, has

> 
> 1. TEST_TYPE_RX_POLL:
> Check if RX path POLLIN function work as expect. TX path

works

> can use any method to sent the traffic.

send

> 
> 2. TEST_TYPE_TX_POLL:
> Check if TX path POLLOUT function work as expect. RX path
> can use any method to receive the traffic.
> 
> 3. TEST_TYPE_POLL_RXQ_EMPTY:
> Call poll function with parameter POLLIN on empty rx queue
> will cause timeout.If return timeout then test case is pass.

space after dot

> 
> 4. TEST_TYPE_POLL_TXQ_FULL:
> When txq is filled and packets are not cleaned by the kernel
> then if we invoke the poll function with POLLOUT then it
> should trigger timeout.
> 
> v1: https://lore.kernel.org/bpf/20220718095712.588513-1-shibin.koikkara.reeny@intel.com/
> v2: https://lore.kernel.org/bpf/20220726101723.250746-1-shibin.koikkara.reeny@intel.com/
> v3: https://lore.kernel.org/bpf/20220729132337.211443-1-shibin.koikkara.reeny@intel.com/
> 
> Changes in v2:
>  * Updated the commit message
>  * fixed the while loop flow in receive_pkts function.
> Changes in v3:
>  * Introduced single thread validation function.
>  * Removed pkt_stream_invalid().
>  * Updated TEST_TYPE_POLL_TXQ_FULL testcase to create invalid frame.
>  * Removed timer from send_pkts().
>  * Removed boolean variable skip_rx and skip_tx.
> Change in v4:
>  * Added is_umem_valid()

for single patches, I believe that it's concerned a better practice to
include the versioning below the '---' line?

> 
> Signed-off-by: Shibin Koikkara Reeny <shibin.koikkara.reeny@...el.com>
> ---
>  tools/testing/selftests/bpf/xskxceiver.c | 166 +++++++++++++++++------
>  tools/testing/selftests/bpf/xskxceiver.h |   8 +-
>  2 files changed, 134 insertions(+), 40 deletions(-)
> 

I don't think these grammar suggestions require a new revision, so:
Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>