netdev - [PATCH ipsec 0/2] xfrm: Fix bugs in stacked XFRM-I tunnels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 10 Aug 2022 18:22:08 +0000
From:   Benedict Wong <benedictwong@...gle.com>
To:     steffen.klassert@...unet.com, netdev@...r.kernel.org
Cc:     nharold@...gle.com, benedictwong@...gle.com, lorenzo@...gle.com
Subject: [PATCH ipsec 0/2] xfrm: Fix bugs in stacked XFRM-I tunnels

This patch set fixes bugs that prevent stacked IPsec tunnels (via XFRM
interfaces) from receiving packets properly. The apparent cause of the
issues is that the inner tunnel’s policy checks fail to validate the
outer tunnel’s secpath entries (since it no longer has a reference to
the outer tunnel policies, and each call validates ALL secpath entries)
prior to verifying the inner tunnel’s. This patch set fixes this by
caching the list of verified secpath entries, and skipping them upon
future validation runs.

PATCH 1/2 Ensures that policies for nested tunnel mode transforms are
checked before additional decapsulation. This ensures that entries in
the secpath are verified while the context (intermediate IP addresses,
marks, etc) can be appropriately matched.

PATCH 2/2 Skips template matching for previously verified entries in
the secpath. This ensures that each tunnel is responsible for
incrementally verifying the secpath entries associated with it.