netdev - Re: [PATCH net 4/4] can: mcp251x: Fix race condition on receive interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220810071924.z3fbou2wbg6s7jjl@pengutronix.de>
Date:   Wed, 10 Aug 2022 09:19:24 +0200
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        linux-can@...r.kernel.org, kernel@...gutronix.de,
        Sebastian Würl <sebastian.wuerl@...ratech.com>
Subject: Re: [PATCH net 4/4] can: mcp251x: Fix race condition on receive
 interrupt

On 09.08.2022 11:50:16, Jakub Kicinski wrote:
> On Tue,  9 Aug 2022 09:53:17 +0200 Marc Kleine-Budde wrote:
> > @@ -1082,6 +1079,18 @@ static irqreturn_t mcp251x_can_ist(int irq, void *dev_id)
> >  			if (mcp251x_is_2510(spi))
> >  				mcp251x_write_bits(spi, CANINTF,
> >  						   CANINTF_RX0IF, 0x00);
> > +
> > +			/* check if buffer 1 is already known to be full, no need to re-read */
> > +			if (!(intf & CANINTF_RX1IF)) {
> > +				u8 intf1, eflag1;
> > +				
> 
> This line is full of trailing whitespace, could you add a fix on top to
> remove it and resend?

Doh! It was me moving both variables there to reduce their scope and
somehow the whitespace slipped in. Here's an updated PR:

https://lore.kernel.org/all/20220810071448.1627857-1-mkl@pengutronix.de/

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)