netdev - Re: [PATCH AUTOSEL 5.19 076/105] net: devlink: avoid false DEADLOCK warning reported by lockdep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220811085648.33664dda@kernel.org>
Date:   Thu, 11 Aug 2022 08:56:48 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Moshe Shemesh <moshe@...dia.com>, Jiri Pirko <jiri@...dia.com>,
        davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 5.19 076/105] net: devlink: avoid false DEADLOCK
 warning reported by lockdep

On Thu, 11 Aug 2022 11:28:00 -0400 Sasha Levin wrote:
> From: Moshe Shemesh <moshe@...dia.com>
> 
> [ Upstream commit e26fde2f5befad0951fe6345403616bf51e901be ]
> 
> Add a lock_class_key per devlink instance to avoid DEADLOCK warning by
> lockdep, while locking more than one devlink instance in driver code,
> for example in opening VFs flow.

I think we can drop this one, no driver locks multiple instances 
in 5.19. The whole infra for that stuff is new. Not that adding 
a lockdep key can hurt in any way..