netdev - Re: pull-request: bpf 2022-08-10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220810211857.51884269@kernel.org>
Date:   Wed, 10 Aug 2022 21:18:57 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Daniel Borkmann <daniel@...earbox.net>
Cc:     davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com,
        ast@...nel.org, andrii@...nel.org, netdev@...r.kernel.org,
        bpf@...r.kernel.org
Subject: Re: pull-request: bpf 2022-08-10

On Wed, 10 Aug 2022 20:53:57 -0700 Jakub Kicinski wrote:
> On Wed, 10 Aug 2022 21:06:24 +0200 Daniel Borkmann wrote:
> > The following pull-request contains BPF updates for your *net* tree.  
> 
> Could you follow up before we send the PR to Linus if this is legit?
> 
> kernel/bpf/syscall.c:5089:5: warning: no previous prototype for function 'kern_sys_bpf' [-Wmissing-prototypes]
> int kern_sys_bpf(int cmd, union bpf_attr *attr, unsigned int size)
>     ^
> kernel/bpf/syscall.c:5089:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> int kern_sys_bpf(int cmd, union bpf_attr *attr, unsigned int size)

Looking at the code it seems intentional, even if questionable.
I wish BPF didn't have all these W=1 warnings, I always worry
we'll end up letting an real one in since the CI only compares 
counts and the counts seem to fluctuate.