netdev - Re: [PATCH net v2] net/tls: Use RCU API to access tls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <166019821457.2125.9933287708425574791.git-patchwork-notify@kernel.org>
Date:   Thu, 11 Aug 2022 06:10:14 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Maxim Mikityanskiy <maximmi@...dia.com>
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, borisp@...dia.com, saeedm@...dia.com,
        tariqt@...dia.com, john.fastabend@...il.com, gal@...dia.com,
        netdev@...r.kernel.org, j.vosburgh@...il.com, vfalico@...il.com,
        andy@...yhouse.net, ayush.sawal@...lsio.com,
        vinay.yadav@...lsio.com, rohitm@...lsio.com, kuniyu@...zon.co.jp,
        dsahern@...nel.org
Subject: Re: [PATCH net v2] net/tls: Use RCU API to access tls_ctx->netdev

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@...nel.org>:

On Wed, 10 Aug 2022 11:16:02 +0300 you wrote:
> Currently, tls_device_down synchronizes with tls_device_resync_rx using
> RCU, however, the pointer to netdev is stored using WRITE_ONCE and
> loaded using READ_ONCE.
> 
> Although such approach is technically correct (rcu_dereference is
> essentially a READ_ONCE, and rcu_assign_pointer uses WRITE_ONCE to store
> NULL), using special RCU helpers for pointers is more valid, as it
> includes additional checks and might change the implementation
> transparently to the callers.
> 
> [...]

Here is the summary with links:
  - [net,v2] net/tls: Use RCU API to access tls_ctx->netdev
    https://git.kernel.org/netdev/net/c/94ce3b64c62d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html